Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131283 / 25.04 / Provide single entry point for installing a custom app #10758

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Guide user to App Wizard when installing custom app. Allow to install an app via YAML.

Testing:

Check ticket

Downstream

Affects Reasoning
Documentation UI has changed

@denysbutenko denysbutenko requested a review from a team as a code owner September 27, 2024 08:22
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team September 27, 2024 08:22
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131283: Provide single entry point for installing a custom app NAS-131283 / 25.04 / Provide single entry point for installing a custom app Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.30%. Comparing base (37e2599) to head (0351135).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10758      +/-   ##
==========================================
+ Coverage   80.27%   80.30%   +0.02%     
==========================================
  Files        1571     1571              
  Lines       51704    51706       +2     
  Branches     5838     5838              
==========================================
+ Hits        41507    41521      +14     
+ Misses      10197    10185      -12     
Flag Coverage Δ
80.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good
Screenshot 2024-09-27 at 14 16 49

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants